Search SRILM-USER Archives

Match: Format: Sort by:
Search:

bug?

From: Alexandre Patry <patryale at ADDRESS HIDDEN>
Date: Mon, 18 Jul 2005 15:15:16 -0400

--=-7/g6Coh13+AjaC5sjv4Y
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

I began to use your excellent library and noticed that in prob.h, in the
functions similar to this one :

inline Prob LogPtoProb(LogP2 prob)
{
    if (prob =3D=3D LogP_Zero) {
        return 0;
    } else {
    return exp(prob * M_LN10);
    }
}

the base of the logarithm is changed via a multiplication.  From what I
understand of the function and of the logarithms
(http://en.wikipedia.org/wiki/Logarithm#Change_of_base), I think that a
division should be used instead.

Thank you,

Alexandre Patry

--=-7/g6Coh13+AjaC5sjv4Y
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Ceci est une partie de message
=?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e=2E?=

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBC2//D2i2b+17RHe0RAt69AJ4ha/xQXfjoItNWwCRv11klOuZougCeJnLe
CjVD6LIOG3jUJnShGc4bLf4=
=v4qR
-----END PGP SIGNATURE-----

--=-7/g6Coh13+AjaC5sjv4Y--

Click here to go to the SRILM home page.